> On Okt. 4, 2014, 8:20 nachm., David Edmundson wrote: > > Your branch name in the review request doesn't make much sense, we're in > > frameworks here. > > > > There's a test file tests/components/progressbar.qml can you run that and > > check things still all look OK. > > > > (btw, if you *want* you can try using gerrit for this review request > > https://techbase.kde.org/Development/Gerrit we're trialling it for > > plasma-framework, it'd be nice to have the opinion from someone new.)
Yeah didn't yet have the mood to try it. Ran the test and everything works as expected. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120489/#review67930 ----------------------------------------------------------- On Okt. 4, 2014, 8:27 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120489/ > ----------------------------------------------------------- > > (Updated Okt. 4, 2014, 8:27 nachm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > To prevent the SvgItem from leaking outside, there is a minimum size (being > the margins) enforced. This leads to the situation where an empty progress > bar still shows a little spot on the left. This patch fixes this. > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/ProgressBar.qml b872c97 > > Diff: https://git.reviewboard.kde.org/r/120489/diff/ > > > Testing > ------- > > Change brightness to zero, no more couple of pixels area in the progress bar. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
