----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120426/#review67642 -----------------------------------------------------------
Ship it! I'm fine with this one, so ok if goes in, tough i was wondering about an alternative approach.. the explicit pause animation looks a bit hacky, i wonder if it would look better using instead the qml state machine? (so that in the state transition there could be a single sequential animation between the frame size and the label opacity) it may be overkill tough - Marco Martin On Set. 29, 2014, 5:17 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120426/ > ----------------------------------------------------------- > > (Updated Set. 29, 2014, 5:17 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Avoid text rendering outside toolbox frame when dragging from corner -> edge > > > Diffs > ----- > > toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml 35f35f1 > > Diff: https://git.reviewboard.kde.org/r/120426/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
