-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120386/
-----------------------------------------------------------

Review request for Plasma.


Bugs: 339428
    https://bugs.kde.org/show_bug.cgi?id=339428


Repository: plasma-desktop


Description
-------

There's no need to call restoreConfiguration() in Component.onCompleted since 
the explicit manipulation of the StackView's sourceFile property in said method 
will already trigger the onSourceFileChanged handler which will 
restoreConfigration() also.

This lead to the issue that for data structures QML cannot compare, like the 
Array of extra items in systray config, triggered the change handler on 
re-assignment by the method running a second time enabling the Apply button.


Diffs
-----

  desktoppackage/contents/configuration/AppletConfiguration.qml 2da918e 

Diff: https://git.reviewboard.kde.org/r/120386/diff/


Testing
-------

Opened config, changed and applied values, switched between pages, in systray 
and digitalclock config. Config restored properly.


Thanks,

Kai Uwe Broulik

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to