> On Sept. 23, 2014, 11:54 a.m., Aleix Pol Gonzalez wrote: > > What do you mean by "scripting" here? > > Marco Martin wrote: > shell scritping, the stuff to do the default layout > > Aleix Pol Gonzalez wrote: > So all the refactoring is so the windowed corona gets scripting? What > does it need scripting for?
the mediacenter or whatever needs a default layout too. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/#review67289 ----------------------------------------------------------- On Sept. 23, 2014, 11:23 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120316/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 11:23 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This is as alternative to https://git.reviewboard.kde.org/r/120270/ > > with this approach it becomes possible for the applications to use scripting, > even tough makes shellcorona even more complicated. > It also introduces a little change in the api between Desktop.qml and > desktopview.cpp that i think it makes sense regardless of the other > components of the patch (and that should really go in before thursday). > > One thing I still think I'll try is to use another corona in this case > (basically simpleshellcorona from the other review request) so it does not > make the code of shellcorona more complex (but will make scripting a bit more > complicated) > > > Diffs > ----- > > shell/CMakeLists.txt e835bf8 > shell/desktopview.h 6aeeeb6 > shell/desktopview.cpp 08c1c32 > shell/main.cpp e737007 > shell/scripting/scriptengine.h 6ce8b51 > shell/scripting/scriptengine.cpp 5b035ea > shell/shellcorona.cpp eeb01af > shell/shellmanager.h eef25aa > shell/shellmanager.cpp f6472cb > shell/standaloneappcorona.h PRE-CREATION > shell/standaloneappcorona.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120316/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
