> On Sept. 22, 2014, 7:03 p.m., Eike Hein wrote: > > I think scaling could use a little more love: > > > >  > > > > Specifically, notice how the time part isn't of uniform size. I guess it > > gets scaled to fit in with the city text size, which is scaled to fit > > horizontally. But in an arrangement like this, it would look nicer if the > > time size was uniform. > > Eike Hein wrote: > Sorry, botched the image embed: > >  > > Martin Klapetek wrote: > Ah yeah, that is because just one label is used for the whole thing, so > when it needs to scale the font down to fit "Manila", it also scales down the > clock font :S > > At this point I'd like to leave this as is for now as fixing it would > require splitting this into two standalone labels and given this change would > not be trivial, I'd leave it for after this gets merged. > > Eike Hein wrote: > Yeah I think that's fine, it's an edge case.
That said, it also means the time size changes a lot while mouse-wheeling to change zones, which is a little less edge case-y and pretty ugly. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67225 ----------------------------------------------------------- On Sept. 22, 2014, 9:59 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120314/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 9:59 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > I've picked up Kai's branch where he started the timezone support and > finished it. > > New features: > * timezones tab in the config > * changing timezones by scrolling a wheel on the clock > * that's optional, defaults to off > * displaying non-local timezones as either city or abbreviation > * "Show time zone" config option is now changed to "Show local time zone" as > foreign zones are always displayed by default > > What's still missing: > * selecting default timezone in the config (should be fairly easy; currently > the last used is restored on login > * timezones in the popup, this would require either large changes to the > applet (moving functions around) or displaying the time in non-locale way > > > > > Diffs > ----- > > applets/digital-clock/plugin/processrunnerplugin.h 2b6317b > applets/digital-clock/plugin/processrunnerplugin.cpp ed039a3 > applets/digital-clock/plugin/qmldir 3d57bbb > applets/digital-clock/plugin/timezonedata.h PRE-CREATION > applets/digital-clock/plugin/timezonemodel.h PRE-CREATION > applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION > dataengines/time/timesource.cpp b79fd7c > applets/digital-clock/package/contents/config/config.qml f897c9a > applets/digital-clock/package/contents/config/main.xml cbeb02f > applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172 > applets/digital-clock/package/contents/ui/configAppearance.qml 01f6878 > applets/digital-clock/package/contents/ui/configTimeZones.qml PRE-CREATION > applets/digital-clock/package/contents/ui/main.qml e78f1f3 > applets/digital-clock/plugin/CMakeLists.txt 0590e6e > applets/digital-clock/plugin/digitalclockplugin.h PRE-CREATION > applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120314/diff/ > > > Testing > ------- > > I've been using it for couple days, all those features from above work nicely > here, with all sorts of config configurations (eg. if date is displayed, it > also changes properly with timezone change). > > > File Attachments > ---------------- > > Timezone & date displayed > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/5462a885-827c-4979-acf4-55da7ea061d4__plasma_clock_tz1.png > Timezone without date > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/fcae7191-84f1-4377-b26a-5d39035c1ca7__plasma_clock_tz2.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
