> On Sept. 15, 2014, 7:58 vorm., Marco Martin wrote: > > looks good. > > but how does it look on Oxygen? (rounded borders of its frames may give a > > problem here) > > Kai Uwe Broulik wrote: > I tried it on oxygen and looked fine. I didn't see it bleeding outside. > But I will check again.
But then shouldn't be an issue since the Rectangle is *inside* the ScrollView and so will be clipped by it accordingly. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120170/#review66516 ----------------------------------------------------------- On Sept. 12, 2014, 7:14 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120170/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 7:14 nachm.) > > > Review request for Plasma and Eike Hein. > > > Repository: plasma-desktop > > > Description > ------- > > This uses the base color (it's white here, I have no experience with syspal) > for the sidebar to match the look of the KConfig thingie used in widget-based > applications. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml 37cec5a > > Diff: https://git.reviewboard.kde.org/r/120170/diff/ > > > Testing > ------- > > Sidebar is white now in Breeze and dark gray on Obsidian Coast. > > > File Attachments > ---------------- > > Screen shot > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/70a948e4-9042-467b-8984-5346a2a027fa__whitesidebar.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
