-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119920/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

This patch restores the original checkbox and radio button size calculation as 
it was before the migration to QtQuick Controls.

On one hand the newer, smaller one size-wise looks closer to the one used in 
Widget/Desktop-style apps but eg. battery monitor looks weird with the smaller 
one.


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml d9dc9fd 
  src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml 
6d06f01 

Diff: https://git.reviewboard.kde.org/r/119920/diff/


Testing
-------

CheckBox looks like it did before, did not test Radio Button, in Radio Button 
it also does away with the hardcoded 6px margin used previously.


Thanks,

Kai Uwe Broulik

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to