----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review65061 -----------------------------------------------------------
klipper/clipboardjob.h <https://git.reviewboard.kde.org/r/119866/#comment45465> forward declare instead of including header - it's only used as a const-ref after all. klipper/clipboardjob.cpp <https://git.reviewboard.kde.org/r/119866/#comment45466> *cough* ;-) klipper/clipboardjob.cpp <https://git.reviewboard.kde.org/r/119866/#comment45468> in case you want to keep the warning: add the job to the lambda's capture and you don't need to use sender() and can get rid of the cast: [this,job](const KFileItem &item) { qWarning() << "PreviewJob failed for" << item.url() << job->errorString(); iconResult(item); } klipper/clipboardjob.cpp <https://git.reviewboard.kde.org/r/119866/#comment45467> why are you getting a fixed-size icon pixmap? Wouldn't it be better to pass the QIcon along, so that it doesn't result in a scaled down icon? - Martin Gräßlin On Aug. 22, 2014, 4:33 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119866/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 4:33 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This patch paints previews of copied images, instead of displaying the urls > in plain text. > > The display is limited to 4 images right now. The painting of the delegates > is in line with the recommendations from the HIG at > https://techbase.kde.org/Projects/Usability/HIG/Layout/Image > > It has a few rough edges: > - not all images get thumbnails -- need to investigate why > - vertical alignment throughout the list is quite bad, this is the case > already, I will fix that separately > - I want to add an indicator that it's more than 4 files (if applicable), > working on that still > - When no preview is loaded, it should show an icon, almost done, with some > fixes > > I'd like some feedback on the code, so that with the remaining issues fixed, > it can get in. > > > Diffs > ----- > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 > applets/clipboard/contents/ui/Menu.qml e6821c3 > applets/clipboard/contents/ui/clipboard.qml ac784d2 > klipper/CMakeLists.txt 660b0d1 > klipper/clipboardjob.h b4f5284 > klipper/clipboardjob.cpp d84d014 > klipper/historyurlitem.cpp fb2a766 > klipper/org.kde.plasma.clipboard.operations 813aafa > > Diff: https://git.reviewboard.kde.org/r/119866/diff/ > > > Testing > ------- > > Copied images and files in Dolphin, see them showing up in Klipper. Made sure > that the previews are only loaded when needed, so no additional memory taken > when the systray / klipper popup is not open. > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png > Klipper with thumbnails > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png > Klipper with thumbnails 2nd version > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
