> On Aug. 20, 2014, 6:38 nachm., Kai Uwe Broulik wrote: > > File Attachment: Klipper with thumbnails - klipper-thumbnails.png > > <https://git.reviewboard.kde.org/r/119866/#fcomment251> > > > > A tooltip might be useful, there's not much room for the filename. > > Sebastian Kügler wrote: > I thought about this as well, but it has a few downsides: > > The tooltip would either > - have to carry all the filenames, or a selection, resulting in a huge > tooltip > - be per preview, which means we'll leave some of them out, and the > delegate becomes very "popuppy", i.e. lots of changes on mouse over, tooltips > covering up other interesting bits, etc > > As I've done the delegate now, the previews are distinguishable and > provide "just enough" information to get a good idea of what's in the buffer. > I'd like to avoid this, as I think showing a tooltip is more of sign of > trying to be overly correct, instead of making an educated choice what to > display. I'll drop this issues, if you're OK with that. If not, we can work > from here and try to find a better solution. Let's try it first, and > experience how it fares (quite well in my testing, so maybe this is a > non-issue).
Sure, your explanation sounds reasonable. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review64924 ----------------------------------------------------------- On Aug. 20, 2014, 6:29 nachm., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119866/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 6:29 nachm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This patch paints previews of copied images, instead of displaying the urls > in plain text. > > The display is limited to 4 images right now. The painting of the delegates > is in line with the recommendations from the HIG at > https://techbase.kde.org/Projects/Usability/HIG/Layout/Image > > It has a few rough edges: > - not all images get thumbnails -- need to investigate why > - vertical alignment throughout the list is quite bad, this is the case > already, I will fix that separately > - I want to add an indicator that it's more than 4 files (if applicable), > working on that still > - When no preview is loaded, it should show an icon, almost done, with some > fixes > > I'd like some feedback on the code, so that with the remaining issues fixed, > it can get in. > > > Diffs > ----- > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml > 8eecb80cff1b5535b43242fe114fdaeae5ad510a > applets/clipboard/contents/ui/clipboard.qml > ac784d2a46961083aad24eb142b9befa74ec61bd > klipper/CMakeLists.txt 660b0d174f9d41eec095d83d640111d1c340fb17 > klipper/clipboardjob.cpp d84d01471440eed670c459e775867eda25fdbc58 > klipper/historyurlitem.cpp fb2a766b39abe2040555ee694c55337481003bf9 > klipper/org.kde.plasma.clipboard.operations > 813aafa96440304b918ef06c3863bd7c4527d62a > > Diff: https://git.reviewboard.kde.org/r/119866/diff/ > > > Testing > ------- > > Copied images and files in Dolphin, see them showing up in Klipper. Made sure > that the previews are only loaded when needed, so no additional memory taken > when the systray / klipper popup is not open. > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png > Klipper with thumbnails > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
