----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/#review64989 -----------------------------------------------------------
Ship it! OK, so normally we would just have one cmake file and 1 version file. However, in plasma we have 2 cmake files and 1 version file. I think as we have the 2 cmake files we need the two version files (this patch) and we do that as we're doing something funky with not installing the headers for plasmaquick. ship it. - David Edmundson On Aug. 21, 2014, 10:30 a.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119881/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 10:30 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able > to set a required KF5 version > > > Diffs > ----- > > src/plasmaquick/CMakeLists.txt cc5554afb2d931611d6949409a5569b409e70b0a > > Diff: https://git.reviewboard.kde.org/r/119881/diff/ > > > Testing > ------- > > compiles and installs, plasma desktop now compiles when I add a required KF5 > version > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
