> On Aug. 14, 2014, 10:25 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/TextArea.qml, line 189 > > <https://git.reviewboard.kde.org/r/119781/diff/1/?file=305255#file305255line189> > > > > would this be useful upstream?
not sure, is quite unusual for multiline controls having a click placeholder text > On Aug. 14, 2014, 10:25 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 35 > > <https://git.reviewboard.kde.org/r/119781/diff/1/?file=305257#file305257line35> > > > > I would lose the "property <type>" prefix > > > > it makes it clear you're just adjusting a property in a parent class, > > not creating anything new. since it inherits the local ScrollViewStyle, that doesn't have a local font proeprty, so has to be declared > On Aug. 14, 2014, 10:25 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 57 > > <https://git.reviewboard.kde.org/r/119781/diff/1/?file=305257#file305257line57> > > > > What's this for? not sure, but the upstream textareastyle has it (not implemented as well) so the control can eventually try to access this property > On Aug. 14, 2014, 10:25 a.m., David Edmundson wrote: > > src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml, line 22 > > <https://git.reviewboard.kde.org/r/119781/diff/1/?file=305258#file305258line22> > > > > did you move the other styles too, or are there now 2 style folders? they are all in plasmacomponents/qml/styles now - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64522 ----------------------------------------------------------- On Aug. 14, 2014, 10:02 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119781/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 10:02 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This ports TextArea to Qtcontrols, all old properties/functions work (except > for errorHighlight that was a stub already) > moves also the scrollview style to make everything in the same place. (needs > to be more complete still before becoming a proper import) > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/TextArea.qml 3f68934 > src/declarativeimports/plasmacomponents/qml/styles/ScrollViewStyle.qml > PRE-CREATION > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml > PRE-CREATION > src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 3818142 > src/declarativeimports/plasmaextracomponents/qml/styles/ScrollViewStyle.qml > cb0b190 > > Diff: https://git.reviewboard.kde.org/r/119781/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
