> On Aug. 13, 2014, 7:01 nachm., Daker Pinheiro wrote: > > applets/clipboard/contents/ui/clipboard.qml, line 107 > > <https://git.reviewboard.kde.org/r/119772/diff/1/?file=305156#file305156line107> > > > > Why not adding the case Qt.Key_Backspace on Switch?
Because it should only ignore that when the filter text is empty, and fall-through conditionally is ugly imho. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119772/#review64494 ----------------------------------------------------------- On Aug. 13, 2014, 6:55 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119772/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 6:55 nachm.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > This patch simplifies the new Klipper plasmoid by removing the custom > highlight implementation and using ListView's highlight property similar to > Kickoff. This also gets rid of the annoying lagging-behind selection > rectangle. > > I also implemented keyboard navigation similar to Kickoff. Open the plasmoid > and start typing and your input will be forwarded to the filter input. Use > arrow up and down to navigate between entries and Return to select them. Not > yet reachable via keyboard only are the action keys (arrow left/right > conflicts with the input and tab also seems wrong. Maybe Shift+Return for > run, Ctrl+B for Barcode, Ctrl+Return for Edit (or Ctrl+E) and Ctrl+Del for > remove? No idea. > > > Diffs > ----- > > applets/clipboard/contents/ui/Menu.qml 8865e43 > applets/clipboard/contents/ui/clipboard.qml 2235b1f > applets/clipboard/contents/ui/ClipboardItemDelegate.qml aa1cf60 > > Diff: https://git.reviewboard.kde.org/r/119772/diff/ > > > Testing > ------- > > Opening Klipper and typing and navigating with arrow keys as well as > selecting items works fine. I also didn't find any major regressions from the > new highlight. > ListView does not handle varying delegate sizes well, unfortunately. We > should limit the size of the delegate to max. the popup's height because when > copying large blocks of code that thing gets almost unusable. Also, setting a > large cacheBuffer could minimize the jumping around while scrolling but might > come with a performance cost when opening the plasmoid as the delegate items > need to be created. > > (I don't know what's wrong with the search input but all my input fields > (KRunner, Widget explorer, ..) are broken atm) > > > File Attachments > ---------------- > > Looks like before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/0cfbbf3c-e221-4ce0-9a9c-0c7d6e25f642__newklipper.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
