----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119739/#review64396 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Aug. 12, 2014, 6:32 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119739/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 6:32 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > The sidebar in the applet configuration which tries to mimic the sidebar in > traditional KCMs is hardcoded to 100px resulting in cramped text on my > machine. > > The grid * 7 is completely arbitrary and I don't like it but I have no idea > what heuristics Qt uses to determin the size of that panel. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml 546b8db > > Diff: https://git.reviewboard.kde.org/r/119739/diff/ > > > Testing > ------- > > It looks fine on my machine (fonts at 180dpi) but somebody with an ordinary > display should definitely verify that. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
