----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119720/#review64373 -----------------------------------------------------------
The name, especially the German translation could be improved IMO. That would also be in line with other changes (example "Network Management" became "Networks"). I'd suggest "Removable Devices" instead of "Device Notifier". Thoughts? - Sebastian Kügler On Aug. 11, 2014, 7:18 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119720/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 7:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This streamlines the device notifier plasmoid. > > - Remove redundand "Available devices" label and only show "No devices > available" if there aren't any (Maybe rename "Device Notifier" to something > less geeky, that replaces the former heading?) > - Use the same Heading as the notifications for the sections > > > Diffs > ----- > > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9070788 > > Diff: https://git.reviewboard.kde.org/r/119720/diff/ > > > Testing > ------- > > Yup. > > > File Attachments > ---------------- > > Device Notifier (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/c44f1937-d712-4516-b0e7-a7177ef3715b__devicenotifyold.png > Device Notifier (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/53c802f5-9d1a-4176-8025-e3b3dab45d93__devicenotifynew.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
