> On Ago. 11, 2014, 6:37 p.m., Martin Klapetek wrote: > > > I have no idea what's wrong with the action button. > > > > This broke since the port to QtQuick Controls' Button, not sure what to do > > about it tho > > Kai Uwe Broulik wrote: > Well, clearly the button's label does not honor the button's custom > height as set by the NotificationsDelegate, as can be easily seen in [1]. > > [1] http://wstaw.org/w/2Thp/ > > Martin Klapetek wrote: > Right, that seems to be the QQC Button limitation. I haven't checked but > I think it gets the default height from the platform style hint and then just > ignores the height as it expects all the buttons to have the same height on > the given platform (which actually makes sense...and also raises some > questions regarding the notification buttons ;) > > Kai Uwe Broulik wrote: > You could still ask control.height, no?
maybe a little test case may be useful (so we can see if it's solvable/have to be solved on our part, or has to be sent as a bug report in qtcontrols - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119719/#review64296 ----------------------------------------------------------- On Ago. 11, 2014, 6:19 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119719/ > ----------------------------------------------------------- > > (Updated Ago. 11, 2014, 6:19 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This streamlines the notification plasmoid a bit. > > - Get rid of hardcoded sizes (was quite cramped here) > > - Get rid of huge "Transfers" heading. It was the same size as the systray > title and added little value > > I have no idea what's wrong with the action button. > > > Diffs > ----- > > applets/notifications/package/contents/ui/Jobs.qml 2f5a88e > applets/notifications/package/contents/ui/NotificationDelegate.qml 0b97d77 > > Diff: https://git.reviewboard.kde.org/r/119719/diff/ > > > Testing > ------- > > Yup. > > > File Attachments > ---------------- > > Notifications (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/da7f1f4e-df8f-4eda-aca8-1c4fcc6fdeda__notifyold.png > Notifications (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/11/1064cc3d-8ae0-4267-ae6e-1643f8a0a23a__notifynew.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
