----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119687/ -----------------------------------------------------------
Review request for Plasma. Repository: kdeplasma-addons Description ------- I would be grateful for some pointers regarding the implementation so far. - Can I somehow make the color choosing reusable? Now I have to write almost 50 lines of repetitive code for each color. - Are there any suggestions regarding the design and usability? Now it's just a Label and a colored Rectangle, which opens a ColorDialog when clicked on. Is there any standard way of implementing color settings? - Is Reviewboard the correct place for this kind of discussion? Diffs ----- applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION applets/systemloadviewer/package/contents/ui/GeneralSettings.qml PRE-CREATION applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119687/diff/ Testing -------  Thanks, Martin Yrjölä
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
