----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ -----------------------------------------------------------
(Updated Aug. 8, 2014, 8:18 p.m.) Review request for Plasma. Changes ------- I have just came up with the idea of adding the option PLASMATE_BUILD_WITH_KDEVPLATFORM. This will allow people to disable the build of plasmate in case they don't want it. This change is located in plasmate/CMakeLists.txt. By default plasmate will be included in the build. Any objections to this one? Repository: plasmate Description ------- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. ---- * use some private members and improve readability ---- * Every project must have a .plasmate file in order to pick the Manager. ---- * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs (updated) ----- CMakeLists.txt 3fc11fb plasmate/CMakeLists.txt 1a6ce87 plasmate/app/katepartui.rc PRE-CREATION plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing ------- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 File Attachments ---------------- How plasmate should look like in the end https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png Thanks, Giorgos Tsiapaliokas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
