> On Aug. 8, 2014, 11:02 a.m., David Edmundson wrote: > > activeshellpackage/package/contents/explorer/CommonDelegate.qml, line 2 > > <https://git.reviewboard.kde.org/r/119660/diff/1/?file=302082#file302082line2> > > > > did you write this or Marco?
Thank you for your review and for pointed those issues out. I pushed before i see your review. I have push a new commit which is solving this issues. As it regards the copyright, this file is actually a port from the Plasma Active 1, this is why i left the copyright. - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119660/#review64044 ----------------------------------------------------------- On Aug. 8, 2014, 11:07 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119660/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 11:07 a.m.) > > > Review request for Plasma. > > > Repository: plasma-mobile > > > Description > ------- > > This patch adds Baloo support to Widget Explorer. > Also the the active containment is now able to load the resources from the > kactivitymanager, > The ones which we added from the Widget Explorer using the Baloo as a > resource indexer. > > > Diffs > ----- > > activeshellpackage/package/contents/explorer/CommonDelegate.qml > PRE-CREATION > activeshellpackage/package/contents/explorer/WidgetExplorer.qml 5073e71 > components/mobilecomponents/CMakeLists.txt 879c2eb > components/mobilecomponents/ResourceDelegate.qml 67ceb67 > components/mobilecomponents/applicationlistmodel.h 7107448 > components/mobilecomponents/applicationlistmodel.cpp 451d4f8 > components/mobilecomponents/resourcedelegates/FileDataObject/Item.qml > 2fa6575 > > components/mobilecomponents/resourcedelegates/FileDataObject/ItemHorizontal.qml > 7dfd003 > components/mobilecomponents/resourcedelegates/Image/Item.qml 743069c > components/mobilecomponents/resourcedelegates/Image/ItemHorizontal.qml > 51b9f27 > containments/activecontainment/contents/ui/ItemsList.qml c9d9919 > containments/activecontainment/contents/ui/ItemsListGroup.qml 9655b31 > containments/activecontainment/contents/ui/main.qml 4d2ba6d > activeshellpackage/package/contents/explorer/AppletDelegate.qml 9afdd52 > activeshellpackage/package/contents/explorer/CommonBrowser.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119660/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Widgets > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/43b31420-6562-4f92-9cb3-b1ff8b503af4__widgets.png > applications > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/bf509e3c-2272-48af-a159-2dad86582a29__applications.png > documents > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/e90bf903-5393-4e16-84c0-07bfb2622db4__documents.png > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
