----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119653/#review64014 -----------------------------------------------------------
Ship it! Thanks for taking care of this! - Kai Uwe Broulik On Aug. 7, 2014, 8:11 nachm., Nikita Skovoroda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119653/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 8:11 nachm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > batterymonitor: Make BatteryIcon animation run only while the BatteryIcon is > visible. > > This change disables the BatteryIcon animation when that icon is not visible. > > Should be trivial to review. > > Before this change, plasma was causing a 10-15% CPU load (at one kernel) when > using a notebook with ac adapter plugged in and the new systemtray is open, > even if different tab from «batterymonitor» is visible. > > With this change, it should not load CPU with this animation when a different > tab is open in systemtray and the batterymonitor tab is not visible. > > > Diffs > ----- > > applets/batterymonitor/package/contents/ui/BatteryItem.qml > e496f0161732f8c7079036c23784cae4a366a595 > > Diff: https://git.reviewboard.kde.org/r/119653/diff/ > > > Testing > ------- > > Works for me. > No regressions observed. > > > Thanks, > > Nikita Skovoroda > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
