----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119634/#review63925 -----------------------------------------------------------
I'd say it's a fine cleanup, but IMHO the efforts should go into the actual porting and figuring out of kdeplasma-addons [1] rather than ensuring the build is clean. [1] https://todo.kde.org/?controller=board&action=show&project_id=11 - Aleix Pol Gonzalez On Aug. 6, 2014, 2:42 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119634/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 2:42 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > There was a huge amount of Frameworks which wheren't needed. also fixed some > deprecation warnings, commented out unused stuff, etc. > > > Diffs > ----- > > CMakeLists.txt a3b134d > dataengines/konsoleprofiles/CMakeLists.txt 1e0a0fc > runners/converter/CMakeLists.txt f0ee664 > runners/dictionary/CMakeLists.txt e5ff6cd > > Diff: https://git.reviewboard.kde.org/r/119634/diff/ > > > Testing > ------- > > builds > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
