> On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > File Attachment: locker.png - locker.png > > <https://git.reviewboard.kde.org/r/119618/#fcomment233> > > > > Do we want a frame round this? > > > > A title of "Lock screen style" might be useful?
around the whole view? maybe > On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > ksmserver/screenlocker/kcm/package/contents/ui/main.qml, line 107 > > <https://git.reviewboard.kde.org/r/119618/diff/1/?file=296885#file296885line107> > > > > I don't like mixing Plasma controls in desktop stuff, it's very easy to > > get white text on a white background. > > > > Why do we need this over QtQuickControls.Button? true, i used this one around also in the wallpaper dialog and the splashscreen one. mostly because it was looking more in style, and smaller than a normal desktop button. In thumbnails is the one place where it may be acceptable, since system colors don't mean much there (since we're painting it over a thumbnail, that can be of any color) aanyways, if this is an issue, i can change it (together wallpaper selection and splash kcm) > On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > ksmserver/screenlocker/kcm/package/contents/ui/main.qml, line 128 > > <https://git.reviewboard.kde.org/r/119618/diff/1/?file=296885#file296885line128> > > > > what's this for? I assume you're working round something. > > > > (and don't reply here, reply in code comments :) ) i'll add it in the comments as well ;) basically, list.setCurrentIndex doesn't work while the model is getting loaded, so list.currentIndex = index in a component.onCompleted of the delegate, doesn't work, restarting a timer when a delegate gets created, seems the only place where we can approximate "set the property when the view really is done loading" > On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > ksmserver/screenlocker/kcm/lockermodel.cpp, line 1 > > <https://git.reviewboard.kde.org/r/119618/diff/1/?file=296884#file296884line1> > > > > http://qt-project.org/doc/qt-5/qstandarditemmodel.html#setItemRoleNames you mean to avoid to subclass the model altogether? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119618/#review63866 ----------------------------------------------------------- On Aug. 5, 2014, 3:18 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119618/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 3:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > one thing that was requested a lot as well, is an override on the screen > locker package as is done in the splash screen as well (master already > supports reading it from config, the kcm to set that was missing tough) > > > Diffs > ----- > > lookandfeel/contents/lockscreen/screenshot.png PRE-CREATION > ksmserver/screenlocker/kcm/lockermodel.h PRE-CREATION > ksmserver/screenlocker/kcm/lockermodel.cpp PRE-CREATION > ksmserver/screenlocker/kcm/package/contents/ui/main.qml PRE-CREATION > ksmserver/screenlocker/kcm/package/metadata.desktop PRE-CREATION > ksmserver/screenlocker/kcm/CMakeLists.txt 17e4f70 > ksmserver/screenlocker/kcm/kcm.cpp d74ab75 > ksmserver/screenlocker/kcm/kcm.ui 1cc2653 > > Diff: https://git.reviewboard.kde.org/r/119618/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > locker.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/05/1174ed52-d86c-4345-9790-0cb5dd8f75ca__locker.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
