-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119617/#review63848
-----------------------------------------------------------
two things:
* perhaps the query should still be executed in a thread
* maybe the syntax from qml would be nicer if the query is in a sub object to
have something like:
BalooModel {
query {
type: "File/Image"
date: "2012/03"
}
}
components/baloodatamodel/baloodatamodel.cpp
<https://git.reviewboard.kde.org/r/119617/#comment44523>
maybe this should be done in a thread?
- Marco Martin
On Ago. 5, 2014, 12:22 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119617/
> -----------------------------------------------------------
>
> (Updated Ago. 5, 2014, 12:22 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-mobile
>
>
> Description
> -------
>
> This component allows us to fetch files from the baloo.
>
>
> Diffs
> -----
>
> CMakeLists.txt e90cec6
> components/CMakeLists.txt 536b60e
> components/baloodatamodel/CMakeLists.txt PRE-CREATION
> components/baloodatamodel/baloodatamodel.h PRE-CREATION
> components/baloodatamodel/baloodatamodel.cpp PRE-CREATION
> components/baloodatamodel/baloodatamodelplugin.h PRE-CREATION
> components/baloodatamodel/baloodatamodelplugin.cpp PRE-CREATION
> components/baloodatamodel/qmldir PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119617/diff/
>
>
> Testing
> -------
>
> Everything works, we can get:
>
> * the file id
> * the file icon
> * the file url
> * the file text
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
