----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/#review63839 -----------------------------------------------------------
kcms/runners/kcm.cpp <https://git.reviewboard.kde.org/r/119602/#comment44510> I'm fairly certain this is going to look bad on my hidpi screen. KIconLoader::SizeMedium is hardcoded to 32. I'm not sure what we should be using though. kcms/runners/kcm.cpp <https://git.reviewboard.kde.org/r/119602/#comment44513> The manager does not seem to be deleted. Is this correct? kcms/runners/kcm.cpp <https://git.reviewboard.kde.org/r/119602/#comment44515> Are you sure this doesn't result in a crash? Either way, it's redundant. kcms/runners/kcm.cpp <https://git.reviewboard.kde.org/r/119602/#comment44516> Why the 1.2? - Vishesh Handa On Aug. 5, 2014, 9:24 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119602/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 9:24 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > unlike the previous one, this still uses category based config. > tough, if in a category there are runners with a config dialog, enable a > config button in the item. > If there would be more runners with config in one category, it would put all > the config dialogs in a tabbar. > The code for showing the config dialog comes from KPluginLoader > > > Diffs > ----- > > kcms/runners/CMakeLists.txt 257baef > kcms/runners/kcm.h 0458430 > kcms/runners/kcm.cpp 0de07fb > > Diff: https://git.reviewboard.kde.org/r/119602/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > krunner.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/04/447dbfb8-e813-4cb9-aabb-a2b9f8d324a0__krunner.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
