> On Aug. 1, 2014, 4:28 p.m., Vishesh Handa wrote: > > Nope. > > > > You're now listing plugins instead of listing categories. > > Marco Martin wrote: > ook, but this gives a couple of problems > Only giving possibility of enabling and disabling categories, altough it > kinda makes sense, makes it hard to respect the runner metadata on wether the > plugin should be loaded by default or not. This is important because internet > accessing runners should always be disabled by default. they may be all > forced in one same category and have that disabled by default, but would be > hard to enforce and for sure i still need distiction (i want to enable > wikipedia, not amazon;) > > The second issue is for configuration of individual runners: some runners > expose a configuration ui, and I don't want to lose that option: some configs > are maybe less necessary (mostly are trigger words) some look very sensible > and i want to keep them, like the media player control one. > > one solution may be to show the config button in the category if there is > only plugin in the category and that plugin offers a configuration ui. > It still doesn't cover the case of categories with more plugins, but > better than nothing
So this can be discarded? - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119557/#review63645 ----------------------------------------------------------- On Aug. 1, 2014, 1 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119557/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 1 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > there is a standard widget to enable or disable plugins used around: > kpluginselector. > this is needed also to access the about dialog of runners (maybe not 100% > needed) and the config dialog some runners have (that's absolutely needed) > graphically looks similar, just a bit more detailed (displays comments from > the metadata files as well) > > note there is still a bug this uncovered before it can be merged (probably > the reason it wasn't used before) the scrollbars are always hidden right now. > that's a problem in kcategorizedview due to a workaround of an old Qt4 bug > update: the scrollbars are now fixed in kcategorizedview > > > Diffs > ----- > > kcms/runners/kcm.h 0458430879964a10b2a15ff6660919874b7a5c3d > kcms/runners/kcm.cpp 0de07fbd73f692acb7b68efa665ba72dc8eddc5b > > Diff: https://git.reviewboard.kde.org/r/119557/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > snapshot4.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/be11d3fa-5de4-496b-a79e-450bd78318e6__snapshot4.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
