----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/#review63781 -----------------------------------------------------------
src/platformtheme/khintssettings.cpp <https://git.reviewboard.kde.org/r/119534/#comment44447> you don't have to initialise SharedPtrs src/platformtheme/khintssettings.cpp <https://git.reviewboard.kde.org/r/119534/#comment44451> I don't think we want to call the default look and feel package something like maybe org.kde.defaultlookandfeel otherwise you're just putting the type in the name which is just confusing. src/platformtheme/khintssettings.cpp <https://git.reviewboard.kde.org/r/119534/#comment44449> so we don't want to be loading the cgIcons group then. src/platformtheme/khintssettings.cpp <https://git.reviewboard.kde.org/r/119534/#comment44450> This means we'll end up with a KCM to change icons that does nothing. That sounds bad? I was under the impression that we were using L&F to get the default icon set if one is not set. - David Edmundson On July 29, 2014, 4:22 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119534/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 4:22 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: frameworkintegration > > > Description > ------- > > there will be support for some kind of "mega theme" that besides providing > files for splashscreen, lockscreen etc, will define what defaults to use > among icons, colors, fonts etc. > > This is a first start of it for reading the defaults. The theme file is > stored in a plasma package, but the patch resolves the correct path by hand, > not requiring linking to libplasma. > right now only a couple of settings is used, mostly to see if the direction > is good. > > > Diffs > ----- > > src/platformtheme/khintssettings.h 57f1864 > src/platformtheme/khintssettings.cpp 104f77c > > Diff: https://git.reviewboard.kde.org/r/119534/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
