----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119283/#review62365 -----------------------------------------------------------
Ship it! Neato! There's one issue in the dimensions calculation of the painted rect as far as I can see. It's not visible, but would be nice to correct (or make sure that I am wrong). Otherwise, this can go in. Have you tried the effect on the loading time of the calendar, by the way? I can imagine this is quite a dramatic improvement compared to the state of about a week ago. src/declarativeimports/calendar/qml/DaysCalendar.qml <https://git.reviewboard.kde.org/r/119283/#comment43321> + root.borderWidth The last cell has two borders here. Can you verify? Same goes for the height. - Sebastian Kügler On July 14, 2014, 9:46 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119283/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 9:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This patch simplifies the grid a bit more by using Canvas instead of > Rectangles, so actually lowering the number of Items needed to create the > grid from 16 to just 1. > > It works pretty neatly with no junctions problem at all. > > > Diffs > ----- > > src/declarativeimports/calendar/qml/DayDelegate.qml d626441 > src/declarativeimports/calendar/qml/DaysCalendar.qml 1249de2 > src/declarativeimports/calendar/qml/MonthView.qml 4946635 > > Diff: https://git.reviewboard.kde.org/r/119283/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot before/after > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/14/e744e403-89ff-4947-95eb-3ade4823ebb5__plasma_cal_canvas.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
