----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119276/#review62362 -----------------------------------------------------------
Ship it! The DATA_INSTALL_DIR -> KXMLGUI_INSTALL_DIR change is correct, feel free to apply it where you see fit. Also I wouldn't do commits re-arranging xml stuff. And if you really want to, I'd suggest to do them all at once. - Aleix Pol Gonzalez On July 14, 2014, 5:22 p.m., Elias Probst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119276/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 5:22 p.m.) > > > Review request for Plasma. > > > Repository: kinfocenter > > > Description > ------- > > The kxmlgui file for kinfocenter is installed into a deprecated location. > This patch fixes this and the deprecation notice on kinfocenter startup isn't > shown anymore (*KXMLGUI file found at deprecated location > ("/usr/share/kinfocenter/kinfocenterui.rc") -- please use > ${KXMLGUI_INSTALL_DIR} to install this file instead.*) > > Besides that, I cleaned up the XML formatting/indendation a bit using xmllint. > > > Diffs > ----- > > CMakeLists.txt fa8b7ce250f14710c487ce26c07a0a2dd9d1f0b8 > kinfocenterui.rc f9846368d733de973623ac64af3064c225d85458 > > Diff: https://git.reviewboard.kde.org/r/119276/diff/ > > > Testing > ------- > > kinfocenter works. > No deprecation notice shown anymore. > > > Thanks, > > Elias Probst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
