----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119233/#review62137 -----------------------------------------------------------
looks good to me, I am not sure the active tab set is written to a config though, if so we'd probably need a kconf_update when reintroducing it (a quick look at the code doesn't immediately suggest that is the case so I guess we'll be fine) - Harald Sitter On July 11, 2014, 2:08 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119233/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 2:08 p.m.) > > > Review request for Plasma, John Tapsell and Harald Sitter. > > > Repository: ksysguard > > > Description > ------- > > Do not load system load by default, graphs are broken currently > > > Diffs > ----- > > gui/Workspace.cpp eaed1a1d85ee5cb6230157ab6f69a5c267efb9e9 > > Diff: https://git.reviewboard.kde.org/r/119233/diff/ > > > Testing > ------- > > removed ksysguardrc config file, restarted ksysguard, does not show > > but you can still add graphs manually and they're still broken > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
