----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119163/#review61844 -----------------------------------------------------------
src/declarativeimports/plasmacomponents/qml/ProgressBar.qml <https://git.reviewboard.kde.org/r/119163/#comment43049> This probably needs Accessible.name: value otherwise a blind person can see it's a progress bar but no idea what the progress is. src/declarativeimports/plasmacomponents/qml/Slider.qml <https://git.reviewboard.kde.org/r/119163/#comment43052> This needs value + increment and decrement functions Obviously your changes are an improvement so you don't need to fix the above before pushing, but if we don't do it now it'll probably get forgotten. - David Edmundson On July 7, 2014, 5:27 p.m., Frederik Gladhorn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119163/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 5:27 p.m.) > > > Review request for Plasma, Sebastian Sauer and Jeremy Whiting. > > > Repository: plasma-framework > > > Description > ------- > > Adds some accessibility properties to the plasma-framework controls. More > work is needed, but these make many elements show up in accessibility helper > tools. > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/TextField.qml d67dda3 > src/declarativeimports/plasmacomponents/qml/ToolBar.qml 91b8f77 > src/declarativeimports/plasmacomponents/qml/ToolButton.qml 21afc21 > src/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml > 8c6919e > src/declarativeimports/plasmacomponents/qml/ProgressBar.qml b85c100 > src/declarativeimports/plasmacomponents/qml/RadioButton.qml 769682b > src/declarativeimports/plasmacomponents/qml/ScrollBar.qml 6b6f9dd > src/declarativeimports/plasmacomponents/qml/SectionScroller.qml 9c6cc2e > src/declarativeimports/plasmacomponents/qml/Slider.qml 8441eb5 > src/declarativeimports/plasmacomponents/qml/Switch.qml 60f179d > src/declarativeimports/plasmacomponents/qml/TabBar.qml 809318a > src/declarativeimports/plasmacomponents/qml/TabButton.qml 21302ef > src/declarativeimports/plasmacomponents/qml/TextArea.qml 0ca6fe5 > src/declarativeimports/plasmacomponents/qml/Button.qml 186a39a > src/declarativeimports/plasmacomponents/qml/CommonDialog.qml 75f0362 > src/declarativeimports/plasmacomponents/qml/Label.qml 033c41c > src/declarativeimports/plasmacomponents/qml/ListItem.qml 4e6d5e7 > src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml 74d81d1 > > Diff: https://git.reviewboard.kde.org/r/119163/diff/ > > > Testing > ------- > > http://blogs.fsfe.org/gladhorn/2014/07/07/plasma-next-accessibility/ > > > Thanks, > > Frederik Gladhorn > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
