> On July 7, 2014, 1:19 p.m., Vishesh Handa wrote: > > containments/desktop/package/contents/ui/AppletAppearance.qml, line 264 > > <https://git.reviewboard.kde.org/r/119155/diff/1/?file=288234#file288234line264> > > > > This function would be called twice. > > > > Maybe - > > > > property Object minimumSize = computeMinimumSize(); > > property int minimumWidth = minimumSize.width; > > property int minimumHeight = minimumSize.height;
could be a good idea (should be a property var minimumSize i think > On July 7, 2014, 1:19 p.m., Vishesh Handa wrote: > > containments/desktop/package/contents/ui/AppletAppearance.qml, line 67 > > <https://git.reviewboard.kde.org/r/119155/diff/1/?file=288234#file288234line67> > > > > The curly brackets aren't really required. Are we supposed to always > > have them even in QML code? > > > > I know it's a requirement in C++ code. maybe not for signal handlers, but in things like ifs i would like to use the same conventions as c++ code, at least where not explicitly problematic in javascript - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119155/#review61808 ----------------------------------------------------------- On July 7, 2014, 12:51 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119155/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 12:51 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > make the applets respect the minimum size, specified by applets, with the > following logic: > if there is a preferred representation, enforce its minimum size, > if there is a compact representation, enforce its minimum size. > > note: the minimum size of the full representation is not enforced if it's not > the preferred one, because it must still be possible to switch to the compact > one. > > this would fix bugs such as > https://bugs.kde.org/show_bug.cgi?id=337069 > > > Diffs > ----- > > containments/desktop/package/contents/ui/AppletAppearance.qml 9149f48 > containments/desktop/package/contents/ui/main.qml a9cf53e > > Diff: https://git.reviewboard.kde.org/r/119155/diff/ > > > Testing > ------- > > * even if the property reading is buried down in a function, property binding > still works correctly. > > * if the minimum size grows, it may happen the case of overlapping applets, > thing that was avoideed with care by the new layout engine. This may be a > blocker in shipping it for 5.0 > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
