----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119015/#review61494 -----------------------------------------------------------
Ship it! Looks to be good, just a small modification and this can go in. browsingbackends/utility/exit/exitbackend.cpp <https://git.reviewboard.kde.org/r/119015/#comment42806> this should not be needed anymore - Shantanu Tushar On June 29, 2014, 3:53 p.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119015/ > ----------------------------------------------------------- > > (Updated June 29, 2014, 3:53 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > This patch fixes the full screen settings of plasma-mediacenter during exit. > Though its bit hackish which I had done. > I would like to make this done better. With this change the pmc will save the > fullscreen settings before exit. > > > Diffs > ----- > > browsingbackends/utility/exit/CMakeLists.txt 48d12a7 > browsingbackends/utility/exit/exitbackend.cpp 9fe6cad > shells/newshell/mainwindow.cpp 97655d8 > > Diff: https://git.reviewboard.kde.org/r/119015/diff/ > > > Testing > ------- > > Done testing with fullscreen enabled and exit && fullscreen disabled and > exit. Both results were as expected. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
