> On June 27, 2014, 11:16 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 65 > > <https://git.reviewboard.kde.org/r/118978/diff/1/?file=284963#file284963line65> > > > > why do we need it here too? > > Martin Gräßlin wrote: > Honestly: I do not know. But I once went through KApplication code on how > to disable session management and it did that in both methods so I used that > when I adjusted klipper and took the code from klipper here. > > David Edmundson wrote: > I'm not very convinced, it will probably transpire that was a workaround > for some bug 10 years ago or something.
"We recommend setting the restart hint in QGuiApplication::saveStateRequest() because most session managers perform a checkpoint shortly after an application's startup." (http://qt-project.org/doc/qt-5/qsessionmanager.html#setRestartHint ) but nevertheless I would keep it in commitDataRequest - it doesn't hurt and is a little bit safer. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118978/#review61110 ----------------------------------------------------------- On June 27, 2014, 5:26 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118978/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 5:26 p.m.) > > > Review request for Plasma and Harald Sitter. > > > Bugs: 336793 > https://bugs.kde.org/show_bug.cgi?id=336793 > > > Repository: plasma-workspace > > > Description > ------- > > [screenlocker/greeter] Disable session management in the greeter > > We don't want to have the greeter being restored on session startup if > one shut down the system from the lock screen. > > BUG: 336793 > > > Diffs > ----- > > ksmserver/screenlocker/greeter/main.cpp > c708a2f9be0ac8a214045d775cc3489d3dfdb5ab > > Diff: https://git.reviewboard.kde.org/r/118978/diff/ > > > Testing > ------- > > shut down system from lock screen before and after change. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
