> On July 1, 2014, 9:08 a.m., Sebastian Kügler wrote: > > kdepasswd/kcm/main.cpp, line 203 > > <https://git.reviewboard.kde.org/r/118974/diff/1/?file=284944#file284944line203> > > > > Perhaps convert to using KMessageWidget, while at it?
I rather not, that would make the patch much larger since KMessageBox seems to be used everywhere. It should be done in another patch. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118974/#review61084 ----------------------------------------------------------- On June 30, 2014, 1:16 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118974/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 1:16 p.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Repository: kde-baseapps > > > Description > ------- > > UserAccount KCM: Change the name using the AccountManager > > Instead of calling chfn, parsing its output (which depends on the > version of chfn which is present) and also additionally requires the > password. > > This is also much more secure since we aren't storing the password in > memory. > > > Diffs > ----- > > kdepasswd/kcm/CMakeLists.txt ddb2ed6 > kdepasswd/kcm/chfnprocess.h 9f962e2 > kdepasswd/kcm/chfnprocess.cpp fca8e25 > kdepasswd/kcm/main.cpp 25f9001 > > Diff: https://git.reviewboard.kde.org/r/118974/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
