> On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: > > I really like the idea. I think we should keep our Scroll* components in to > > ease porting, but move away from using it for our own stuff first, and > > then, before a first API promise, revisit if we can remove our own > > implementation (which I really hope we'll be able to). > > > > I'd also like to read Marco's opinion on this. > > Mark Gaiser wrote: > Have you heard of QML Plugin versions? The import line with a version > behind it. > You can safely remove what you want and just give it a new version number. > > Marco Martin wrote: > To me in general is a good idea and is fine as long as the api stays the > same (eventually adding missing properties back if any) > > Marco Martin wrote: > on this in particular, ScrollBar.qml was public api, so shouldn't be > removed, even if not used by this component in partibular. > > apart from that is good to go.
Any news on this? Plasma-NM has recently switched over to a QtQuick Controls ScrollView, and so did I. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review45057 ----------------------------------------------------------- On Dec. 3, 2013, 7:09 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114283/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 7:09 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Use QtQuickControls ScrollView internally > > Flickable has a very odd API in which contentHeight can't be trusted. we need > to update our ScrollBars/ScrollArea to make use of the new > originX and originY in order to fix a lot of bugs that we currently see with > scrollbars. > > Instead of doing that, by porting to use QtQuick Controls we get all > these bug fixes as well as _significantly_ reducing our code. > > Having a separate logic vs UI, makes things (IMHO) easier to read. > > I don't expect to merge this as-is; I haven't included the plasma > feature that creates a SectionScroller if the content is a listview, but > that should be viable. As far as I know all other features (keyboard > controls / hiding buttons on touch screens) are still kept. > > Files removed are as indication as to long term changes from making this > change, in order to do that we need to port all users from ScrollBars -> > ScrollArea. (which is worth doing anyway IMHO) > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/ScrollBar.qml 93d7baf > src/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.qml > 6b5edf0 > src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 20cd943 > > Diff: https://git.reviewboard.kde.org/r/114283/diff/ > > > Testing > ------- > > Widget Explorer in plasma-shell looks exactly as before. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
