> On June 19, 2014, 8:16 a.m., Shantanu Tushar wrote: > > Good analysis and fix. It is still broken if you do the following- > > 1. Have multiple playlists > > 2. Remove a playlist > > 3. Add a playlist > > > > After this the highlight again stops to work, can you check?
Hmm I can no longer reproduce this, seems to work :/ Maybe I wasn't running the correct patched binary in a hurry at office. - Shantanu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118824/#review60467 ----------------------------------------------------------- On June 19, 2014, 6:51 a.m., Ashish Madeti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118824/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 6:51 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 336414 > http://bugs.kde.org/show_bug.cgi?id=336414 > > > Repository: plasma-mediacenter > > > Description > ------- > > Whenever we added / removed any playlist, the highlight was stuck at one > point i.e changing the playlist after that was not changing the highlight. > > This was happening because we were directly assigning value to > "multiplePlaylistList.currentIndex" in qml code, which removed its previous > binding. Instead we should emit the currentIndexChanged() signal and let the > ListView do the rest. > > > Diffs > ----- > > libs/mediacenter/multipleplaylistmodel.cpp 87601f5 > mediaelements/playlist/MultiplePlaylists.qml 4b085fe > > Diff: https://git.reviewboard.kde.org/r/118824/diff/ > > > Testing > ------- > > Changed playlist after adding / removing a playlist. Now highlight is working > fine > > > Thanks, > > Ashish Madeti > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
