----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118791/ -----------------------------------------------------------
(Updated June 19, 2014, 12:32 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description ------- This is an experiment. I've removed the scroll area in the KRunner, and now all of the results are shown. I'm not totally convinced if this is a good idea, hence the review request. Advantages - * You can see all of the results Disadvantages - * Consumes more space * Less consistent with the old runner as now it no longer has a scroll area Currently the way the code is structured, the model only shows 20 results. We need to tell the model a maximum number as it decides how many results should be shown per category based on that number. Diffs ----- lookandfeel/contents/runcommand/RunCommand.qml 7a0503d Diff: https://git.reviewboard.kde.org/r/118791/diff/ Testing ------- File Attachments ---------------- Krunner in its full view https://git.reviewboard.kde.org/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac9158215555__krunner.png Thanks, Vishesh Handa
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
