> On June 18, 2014, 7:14 p.m., Hrvoje Senjan wrote: > > in the end this causes massive issues on startup - kdeinit blocks as it > > waits on PA, which i guess is tried to initialize too early. meaning the > > whole startup is 'freezed' (you can interact with shell, but everything > > else is kapput) until the timeout is done/PA process is killed. another > > sideeffect is that it makes ksplash last for inappropriate amount of time > > (bug 336396). local revert resolved those problems completely here. note, i > > have sound notifications off, and haven't enabled plasma_workspace > > notifications > > Martin Klapetek wrote: > Fix your pulseaudio! :P > > More seriously, this might indeed be caused by the initialization of > Phonon. I was thinking a while back if the notification internals > could/should run in its own thread...or maybe we can just move the > notification invocation inside the ksmserver into its own thread and make it > not wait (the sound finishes and the thread destroys itself)? > > Mark Gaiser wrote: > @Martin: yes please! :D > I have the same issue as Hrvoje describes. > > But you also say "fix your pulseaudio".. how? Since fixing that would > seem like a nice workaround, I only have no clue what i need to fix and > where..
Until we have a proper fix for the delay, let's revert this patch. I definitely don't want the desktop to take 30 seconds longer to log in, just because someone might want a login sound. It's just not worth it. If nobody shouts, or beats me to it (preferred), I'll revert this later today. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118636/#review60439 ----------------------------------------------------------- On June 13, 2014, 3:42 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118636/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 3:42 p.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Bugs: 335948 > https://bugs.kde.org/show_bug.cgi?id=335948 > > > Repository: plasma-workspace > > > Description > ------- > > This returns the feature of having and configuring login/logout sounds for > workspace; default remains off for both. > > Additionally to this, I've made KNotification close immediately if there are > no actions defined for the given event, so it won't even try (and wait for) > all the notify plugins. > > > Diffs > ----- > > ksmserver/CMakeLists.txt 71ad4fc > ksmserver/plasma_workspace.notifyrc PRE-CREATION > ksmserver/server.h f813394 > ksmserver/shutdown.cpp 6a6dca9 > ksmserver/startup.cpp 6f5d502 > > Diff: https://git.reviewboard.kde.org/r/118636/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
