-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118753/#review60207
-----------------------------------------------------------


This review has been submitted with commit 
76175fafa6d3a38d739c0ab016528010040068fc by Kai Uwe Broulik to branch master.

- Commit Hook


On June 15, 2014, 12:01 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118753/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 12:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Now that we can handle mouse wheel events with QtQuick 2, we should.
> 
> It mimics QSlider's behavior meaning scrolling vertically up (angleDelta.y > 
> 0) and scrolling horizontally right (angleDelta.x < 0 - though WheelEvent 
> documentation suggests otherwise) is treated the same. Anyone with a 
> mousewheel that can actually scroll sideways is invited to test. Also 
> WheelEvent behaves erratic when scrolling horizontally on my touchpad 
> (reporting 1 digit y values instead of proper x values)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/Slider.qml 142040a 
> 
> Diff: https://git.reviewboard.kde.org/r/118753/diff/
> 
> 
> Testing
> -------
> 
> Tested in a horizontal slider with both mouse and touchpad scrolling with 
> either vertical or (by holding Alt) horizontal scrolling
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to