----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review60178 -----------------------------------------------------------
src/klocalizedstring.h <https://git.reviewboard.kde.org/r/118678/#comment41928> The docstring should not at all mention "application" or refer to availableApplicationTranslations. The return set should always contain en_US, no matter whether setApplicationDomain was called or not. src/klocalizedstring.cpp <https://git.reviewboard.kde.org/r/118678/#comment41930> Should not touch s->applicationDomain. Instead, the call to this method in availableApplicationTranslations should be placed only if the application domain was set, otherwise availableApplicationTranslations should return empty set. - Chusslove Illich On June 16, 2014, 2:01 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118678/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 2:01 a.m.) > > > Review request for Plasma, Chusslove Illich and John Layt. > > > Repository: ki18n > > > Description > ------- > > Allow querying for translations of a specific domain > > In the new translations KCM, we want to list available languages for the > workspace. This might, or might not be the same application domain as > the one set (current translation is different from installed > translations). In order to list the installed translations, we need to > specify that domain, independently from the one set in > KLocalizedString's global static. > > With this patch, I can successfully list installed languages in the new KCM. > > > I'm not super-familiar with how this stuff works, there might be a better > way, > in which case I'm sure you guys will enlighten me. :) > > > Diffs > ----- > > src/klocalizedstring.h 1a9fce8 > src/klocalizedstring.cpp e12d6df > > Diff: https://git.reviewboard.kde.org/r/118678/diff/ > > > Testing > ------- > > Tested new translations KCM, languages show up. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
