----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/ -----------------------------------------------------------
(Updated June 14, 2014, 6:40 p.m.) Review request for Plasma, Jonathan Riddell and Vishesh Handa. Changes ------- Further testing showed that the include directory was incorrectly referenced in a few places. Bugs: https://bugs.gentoo.org/show_bug.cgi?id=512334 http://bugs.kde.org/show_bug.cgi?id=https://bugs.gentoo.org/show_bug.cgi?id=512334 Repository: kfilemetadata Description ------- Turn KFileMetaData into a Framework. Diffs (updated) ----- src/typeinfo.h 2675cbbd5751de9a7ac77cf9fdda4cb6d0a7806e src/propertyinfo.h bb54f58c750eff8c39685861a5346c025265949b src/extractors/CMakeLists.txt 0099c0878315a07f4d7b1369dc1471a8401f10a7 src/extractorpluginmanager.h d4a871e7d5952edb48c5836769741d7cf20bd29f src/extractorplugin.h 218ef207982e31f0142983d75b4846cd0f45f02a src/extractionresult.h 76dfe590aaf1f1fda265a4835fa1bcdbc81ba58a src/CMakeLists.txt 82dbd5c32050081642e9fff958d229f55893d40c autotests/CMakeLists.txt c657a7002d1d0644d6de4438a193bb63657b7ec0 KFileMetaDataConfig.cmake.in b4d1c93b7a23ffcbb03a89e9d4a11559d7e22037 KF5FileMetaDataConfig.cmake.in PRE-CREATION CMakeLists.txt 5a9eefa89b2fc7e6202347daf105baa867328ffc Diff: https://git.reviewboard.kde.org/r/118512/diff/ Testing ------- Tested compiling Baloo against a system install with this patch applied. Baloo sucessfully linked against the KF5 version and all Baloo tests ran to completion. All KFileMetaData unit tests passed too ;) Thanks, Matthew Dawson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
