----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118734/#review60061 -----------------------------------------------------------
libs/mediacenter/mpris2/mediaplayer2player.cpp <https://git.reviewboard.kde.org/r/118734/#comment41814> { } please libs/mediacenter/mpris2/mediaplayer2tracklist.h <https://git.reviewboard.kde.org/r/118734/#comment41815> C++11 magic: you can just say- int tidCounter = 0; libs/mediacenter/mpris2/mediaplayer2tracklist.cpp <https://git.reviewboard.kde.org/r/118734/#comment41816> not needed (see above) - Shantanu Tushar On June 13, 2014, 5:13 p.m., Ashish Madeti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118734/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 5:13 p.m.) > > > Review request for Plasma, Emmanuel Pescosta, Shantanu Tushar, and Sinny > Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > Added a MPRIS specifications Tracklist Interface, which will expose and give > control over the current playlist on dbus. > http://specifications.freedesktop.org/mpris-spec/latest/Track_List_Interface.html > > > Diffs > ----- > > libs/mediacenter/CMakeLists.txt 8d95cfc > libs/mediacenter/mpris2/mediaplayer2player.h 7a2f583 > libs/mediacenter/mpris2/mediaplayer2player.cpp 2de56c2 > libs/mediacenter/mpris2/mediaplayer2tracklist.h PRE-CREATION > libs/mediacenter/mpris2/mediaplayer2tracklist.cpp PRE-CREATION > libs/mediacenter/mpris2/mpris2.h 1dd78ca > libs/mediacenter/mpris2/mpris2.cpp b64ba04 > shells/newshell/mainwindow.cpp 3c888f8 > > Diff: https://git.reviewboard.kde.org/r/118734/diff/ > > > Testing > ------- > > Tested the properties using qdbusviewer. > I created a qt console application for testing whether the signals are being > emitted correctly and the methods are working. > > > Thanks, > > Ashish Madeti > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
