> On June 7, 2014, 10:26 p.m., David Edmundson wrote: > > Looks good to me. > > Can you check if we need to update the the similar code in in > > kdeclarative->kquickcontrols too. (or poke me repeatedly to do it). > >
It's broken there as well, fix is the same as this one: https://git.reviewboard.kde.org/r/118630/ - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59532 ----------------------------------------------------------- On June 6, 2014, 12:39 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118581/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 12:39 a.m.) > > > Review request for KDE Frameworks, Plasma and Vishesh Handa. > > > Bugs: 335316 > https://bugs.kde.org/show_bug.cgi?id=335316 > > > Repository: kxmlgui > > > Description > ------- > > Consider Super_L and Super_R as modifiers > > Without this patch, I can't use the meta key to assign shortcuts, as > Super_L and Super_R are not considered as modifiers, so when I press > meta (Super_L on my system), the shortcut is immediately accepted, > before I get the chance to press another key. > > This patch requires the fix in > https://bugreports.qt-project.org/browse/QTBUG-38428 > to be applied. With both patches, KKeySequenceWidget works for me. > > BUG:335316 > > > Diffs > ----- > > src/kkeysequencewidget.cpp b6fcd207a1d18466f4a747e1a0b4b58107c82871 > > Diff: https://git.reviewboard.kde.org/r/118581/diff/ > > > Testing > ------- > > Tried to assign meta + something in global shortcuts KCM, fails without patch > (see screenshot in the linked bugreport), works correctly with patch. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
