> On June 4, 2014, 9:04 a.m., Martin Gräßlin wrote: > > looks good to me. Where is the KCM living where one can select the window > > manager? > > Hrvoje Senjan wrote: > it is in plasma-desktop repo. but i did not want to add a patch for > something that does not build ;-) > 1) uses Q_WS_X11 (easy to change) > 2) there's some NETRootInfo usage which got change, and i'd rather leave > the port to an expert > > Martin Gräßlin wrote: > all right, it's on my todo list > > Martin Gräßlin wrote: > kcm is fixed as of b384cb36f1dff98a97956ad51d9d6f004508b346 - a quick > look at the code indicates that some work is needed there as it starts a kwin > process.
well, that NETRootInfo looked more scary ;-) will try to adjust today the kcm - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/#review59121 ----------------------------------------------------------- On June 3, 2014, 3:22 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118482/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 3:22 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > as per dependant review, adjust ksmserver usage of KWin name. (IOW make sure > kwin_x11 is started) > > > Diffs > ----- > > ConfigureChecks.cmake 8e6a87a > ksmserver/config-ksmserver.h.cmake 939632c > ksmserver/server.cpp 644013b > ksmserver/startup.cpp 6f5d502 > > Diff: https://git.reviewboard.kde.org/r/118482/diff/ > > > Testing > ------- > > using it for some ~10 days, noticed no regression. > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel