> On June 4, 2014, 11:02 a.m., Lukáš Tinkl wrote: > > How would you connect to a VPN in that case? > > Marco Martin wrote: > Is networkmanager used to connect a VPN? > (and more generally, are there any features in the plasmoid that can be > used without networkmanager running?) > > Lukáš Tinkl wrote: > Yes it is and I think in that case the NM process is started on demand > when you activate a VPN connection. > > I can't think of any other features using this. > > Marco Martin wrote: > Ok, if it's started on demand (can you confirm that?) then means the > applet is useful without networkmanager running, so the dbus activation > doesn't apply there. > > Sebastian Kügler wrote: > I've never seen the NetworkManager process (and thus its dbus interface) > being started on demand by activating a connection. (Doesn't mean it does, > just that my use-cases are different, and it deserves a second look). The > applet bails out with an error if NetworkManager isn't started, it won't list > anything (not even VPN connections) in that case. > > The approach to load it on-demand seems fine to me. > > Jan Grulich wrote: > You can use VPN connections without NetworkManager and I think that this > patch makes sense, because plasma-nm is useless when NetworkManager is > running. > > Marco Martin wrote: > So I pushed it for now. IF it causes problems can always be reverted > > Hrvoje Senjan wrote: > seems is not working as expected (here at least) > i have org.freedesktop.NetworkManager at system bus, but applet isn't > loaded
Ah, right, it was monitoring only the session bus. Does it work correctly with the latest plasma-workspace revision? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118516/#review59153 ----------------------------------------------------------- On June 4, 2014, 12:13 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118516/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 12:13 p.m.) > > > Review request for Network Management and Plasma. > > > Repository: plasma-nm > > > Description > ------- > > This makes the networkmanagement applet load automatically when the dbus > service org.freedesktop.NetworkManager is present and unloads it when it's > not. > In a normal setup shouldn't make much difference, but would automatically > disable it for workstations when a fixed ip or dhcp over ethernet is used > instead of networkmanager > > > Diffs > ----- > > applet/metadata.desktop 7eafa44 > > Diff: https://git.reviewboard.kde.org/r/118516/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel