----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59065 -----------------------------------------------------------
if you want to enforce to use the same type on all, you can call qMax<double>() and remove all the casts. - Aleix Pol Gonzalez On June 3, 2014, 1:48 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118487/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 1:48 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > floor() returns double, qreal is a typedef and could be float (for example), > so running a qmax(qreal, floor) may cause build failures > > > Diffs > ----- > > src/declarativeimports/core/framesvgitem.cpp > def17ea551340e952ce1a9c52d8e7df308b2b8f1 > > Diff: https://git.reviewboard.kde.org/r/118487/diff/ > > > Testing > ------- > > > Thanks, > > Harald Sitter > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
