> On May 22, 2014, 2:56 p.m., David Edmundson wrote: > > I'm not sure it complies with > > http://techbase.kde.org/Projects/Usability/HIG/SearchPattern > > > > which states filter boxes should always be visible.
that's a good point. I'll put that up in a different review though, as it might be more difficult (I'm not yet that familiar with klippers code base) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118204/#review58301 ----------------------------------------------------------- On May 19, 2014, 3:05 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118204/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 3:05 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > [klipper] Show filter widget before sending key events to it > > Klipper is supposed to show a filter widget when starting to type. > This is done by forwarding the QKeyEvent to the not visible widget. > This seems to have broken in the Qt5 port. Instead of passing to the > widget it's send again to the KlipperPopup resulting in recursive calls > to the same method which in the end crashes Klipper. > > By showing the widget before sending it the key event, everything is > fine. In case that the widget is empty after processing the key event > it gets hidden nevertheless. > > > Diffs > ----- > > klipper/klipperpopup.cpp 574f2d7a0d0b30f94c72b2e2715778f619539a00 > > Diff: https://git.reviewboard.kde.org/r/118204/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
