> On May 22, 2014, 11:40 a.m., Michael Palimaka wrote: > > Where is the kpty usage located? > > Jonathan Riddell wrote: > When compiling without kpty installed: > > In file included from /usr/include/KF5/KDESu/kdesu/stubprocess.h:13:0, > from /usr/include/KF5/KDESu/kdesu/suprocess.h:15, > from /usr/include/KF5/KDESu/kdesu/su.h:2, > from ../../kdesu/sudlg.h:13, > from ../../kdesu/sudlg.cpp:7: > /usr/include/KF5/KDESu/kdesu/ptyprocess.h:22:18: fatal error: kpty.h: No > such file or directory > #include <kpty.h> > ^ > compilation terminated. > > > Hrvoje Senjan wrote: > build should even fail earlier then: kpty is kdesu's public dependancy
Aren't the parent includes from the framework kdesu? - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118257/#review58292 ----------------------------------------------------------- On May 22, 2014, 11:23 a.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118257/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 11:23 a.m.) > > > Review request for Plasma. > > > Repository: kde-cli-tools > > > Description > ------- > > explicit dependency on kpty as needed by kdesu > > > Diffs > ----- > > CMakeLists.txt fa32ecc12e9f17c1925c79729bd3aa346f75fa04 > > Diff: https://git.reviewboard.kde.org/r/118257/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel