----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/#review58196 -----------------------------------------------------------
I quite like the idea. Some comments below. freespacenotifier/freespacenotifier.cpp <https://git.reviewboard.kde.org/r/118205/#comment40456> In Qt5, QStringLiteral is preferable for the QL1S, at least that's what we've been using in the past months quite consistently. (Also goes for the other usages of QL1S.) freespacenotifier/freespacenotifier.cpp <https://git.reviewboard.kde.org/r/118205/#comment40457> For new code, let's use the compile-time checked connect syntax. Makes it easier to spot errors. - Sebastian Kügler On May 19, 2014, 4:15 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118205/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 4:15 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Currently it's done purely as a notification, which doesn't make much sense. > This patch turns it into a regular SNI. The actions were moved from the > notification popup to the SNI menu. > > > Diffs > ----- > > freespacenotifier/freespacenotifier.h d3c0351 > freespacenotifier/freespacenotifier.cpp cdf9bc5 > > Diff: https://git.reviewboard.kde.org/r/118205/diff/ > > > Testing > ------- > > Works properly. > > > File Attachments > ---------------- > > Screenshot (fonts are broken for some reason here) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/19/a918c329-5679-4aeb-9b2e-af260c0bb4d6__fsn_sni.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
