-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118150/#review57996
-----------------------------------------------------------

Ship it!


Looks good


startkde/startkde.cmake
<https://git.reviewboard.kde.org/r/118150/#comment40364>

    Remove?


- Martin Klapetek


On May 15, 2014, 4:47 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118150/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 4:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> QLocale, as opposed to KLocale picks up environmental variables such as LANG, 
> LC_NUMERIC, etc. from the environment. In order to set up the locale 
> correctly, those need to be exported in a Plasma session. startkde does this 
> by sourcing a file with export statements, which has been written by the new 
> Formats KCM. This patch implements the startkde portion of it.
> 
> 
> Diffs
> -----
> 
>   startkde/startkde.cmake c997c39 
> 
> Diff: https://git.reviewboard.kde.org/r/118150/diff/
> 
> 
> Testing
> -------
> 
> Set locale settings in kcmshell5 formats, re-logged in, checked that we get 
> the right QLocale settings (for example in Plasma's clock).
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to