----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118110/#review57865 -----------------------------------------------------------
YES! I HAZ THUMBNAILS! ...confirming this works on my machine with binary nvidia, where it was broken before. Good job! Testing it for a while shows one artifact tho --> http://i.imgur.com/eoUJcez.png -- happens mostly randomly; not sure where the bug of this lies however. - Martin Klapetek On May 13, 2014, 9:02 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118110/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 9:02 a.m.) > > > Review request for Plasma and Martin Klapetek. > > > Bugs: 334241 > http://bugs.kde.org/show_bug.cgi?id=334241 > > > Repository: plasma-framework > > > Description > ------- > > [declarative/core] Use proper GLXFBConfig for glxpixmap > > We need to use a GLXFBConfig which matches the depth of the window > pixmap's depth. So far it used the GLXFBConfig of the GL context. > This worked fine for RGBA windows, but failed for RGB windows on e.g. > some NVIDIA drivers. > > After this change the FBConfig of the context is completely ignored, > instead it tries to find a good FBConfig for a given depth. > > Whenever a FBConfig for a given depth is found it's inserted in a > cache shared between all WindowThumbnails so that we don't have the > X roundtrips all the time. > > BUG: 334241 > > > Diffs > ----- > > src/declarativeimports/core/windowthumbnail.h > d3a7b64ad3594006bdcd689984f55290a4ed4576 > src/declarativeimports/core/windowthumbnail.cpp > c91d1896553f6eecc6828497724d6b119900e40e > > Diff: https://git.reviewboard.kde.org/r/118110/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
